Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows binary support #34

Open
lukebelbina opened this issue Jan 8, 2025 · 6 comments
Open

Windows binary support #34

lukebelbina opened this issue Jan 8, 2025 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@lukebelbina
Copy link
Contributor

On the readme it says there are windows binaries on the releases but I noticed after 1.0 there are no longer windows binaries.

Do you know if this is a mistake or have you dropped support for deploying windows binaries?

Thanks for all the work!

@Propfend
Copy link
Collaborator

Propfend commented Jan 9, 2025

thats true, i can try to add it.

@mcharytoniuk
Copy link
Member

@lukebelbina We intially supported Windows binaries before rewriting the project to Rust + Pingora for better networking features. We planned to add it back, but just didn't do that yet.

@Propfend Thanks a lot. :)

@mcharytoniuk mcharytoniuk added the enhancement New feature or request label Jan 9, 2025
@lukebelbina
Copy link
Contributor Author

Awesome sounds good. Any idea on the ETA? No rush on my end, I have a spare windows gaming machine lying around I'd like to throw into my cluster.

@Propfend
Copy link
Collaborator

whats "ETA"?

@mcharytoniuk
Copy link
Member

@Propfend

whats "ETA"?

Estimated time of arrival/estimated time on how long it will take to finish the task.

@lukebelbina

We need to reconfigure the GitHub workflow and add some cross-compile scripts to generate downloadable .exe files, but from what we tested, it works fine under Windows. Idk, it will maybe take a day or two.

You can also try compiling the project on your own in the meantime - you only need Rust (and Node if you need the web dashboard). Just cloning the repo and running cargo build should be enough.

If you need the web dashboard, then you first need to create front-end assets with this:

paddler/Makefile

Lines 29 to 48 in 9eb79e3

npm exec esbuild -- \
--bundle \
--asset-names="./[name]" \
--entry-names="./[name]" \
--format=esm \
--loader:.jpg=file \
--loader:.otf=file \
--loader:.svg=file \
--loader:.ttf=file \
--loader:.webp=file \
--metafile=esbuild-meta.json \
--minify \
--outdir=static \
--sourcemap \
--splitting \
--target=safari16 \
--tree-shaking=true \
resources/css/reset.css \
resources/css/page-dashboard.css \
resources/ts/controller_dashboard.tsx \

Then cargo build --features web_dashboard later.

@Propfend
Copy link
Collaborator

Yes, and the cross compiling to MacOS is really a pain, its toolchain is not provided, so we just cant include this OS as target on the workflow. And what we have are some very hard workarounds like osxcross, which after building, may still fail in a MacOS device. I wonder how thats done in golang though.

@Propfend Propfend mentioned this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants