Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming #75

Open
emilk opened this issue Nov 8, 2019 · 2 comments
Open

Naming #75

emilk opened this issue Nov 8, 2019 · 2 comments

Comments

@emilk
Copy link

emilk commented Nov 8, 2019

Bike shedding time!

Are the names Copy, Insert, Remove, Change based on some convention?

I find Copy confusing - to me it sounds like maybe an element has been duplicated, as in diff([A], [A, A]) would yield [Copy(0), Copy(0)] or something like that. Maybe Identical or Same is a better name?

Change also seems a bit generic. Replace sounds better to my ears.
@Jim-Holmstroem
Copy link
Contributor

Agreed
Copy => Same (we have the Same concept already and it fits nicely)
Change => Replace could probably work, I need to change it and see how it falls out but great suggestions!

@scooter-dangle
Copy link

Eph tea eph ehy:

Change => Replace could probably work, I need to replace it and see how it falls out but great suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jim-Holmstroem @scooter-dangle @emilk