Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate unremovable component #212

Open
d-beezee opened this issue Nov 27, 2024 · 1 comment
Open

Duplicate unremovable component #212

d-beezee opened this issue Nov 27, 2024 · 1 comment
Assignees

Comments

@d-beezee
Copy link

I imported a component in advanced mode, then i removed it and tried to import it with the s2d parameter from the story.
There are multiple instances of this component, with remove and edit disabled.

This is the path for another instance of the duplicated component RyHZCYe4xcsFodXKuktW/sUKDyomJGjn8aYPtGDnM/1z0t8441bp7fto


Bug report identity: Please do not edit

Task path: RyHZCYe4xcsFodXKuktW/sUKDyomJGjn8aYPtGDnM/tptsczafbb1h

@muryoh muryoh self-assigned this Jan 6, 2025
@muryoh
Copy link
Member

muryoh commented Jan 6, 2025

Hi @d-beezee , sorry for the late feedback!

Unfortunately I was unable to reproduce your issue - I'm wondering if I got it wrong:

  1. import a component in advanced mode, add it to canvas
  2. remove that component
  3. add the same advanced mode configuration directly to Storybook story through thes2d parameter

At that point, my understanding is that you have 2 (more?) instance of the component in the plugin and cannot remove any
From my reproduction path:

  • after step 3., I have only one component in the plugin, which indeed cannot be removed as it is reflecting the s2d parameter
  • even if I omit step 2., I after step 3. I have 2 components, one that can be removed another that cannot

Here are a couple screenshots showing the situation when not removing the manual one. First cannot be removed:
image
But second one can be:
image

Would you mind trying to reproduce yourself and tell me what I missed?

Cheers,
Remy

@muryoh muryoh assigned d-beezee and unassigned muryoh Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants