Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple opentelemetry dependencies #1485

Open
1 of 3 tasks
divergentdave opened this issue Jan 9, 2025 · 0 comments
Open
1 of 3 tasks

Multiple opentelemetry dependencies #1485

divergentdave opened this issue Jan 9, 2025 · 0 comments
Assignees

Comments

@divergentdave
Copy link
Collaborator

divergentdave commented Jan 9, 2025

Since #1448, we have dependencies on opentelemetry 0.24 and opentelemetry 0.27. The former is pulled in by trillium-opentelemetry 0.9. This will prevent us from getting traces and metrics for HTTP requests, since the instrumentation library and the exporter crate will be using different global variables. We should do the following.

  • Submit a PR to trillium-opentelemetry to add compatibility with this version of opentelemetry
  • Upgrade trillium-opentelemetry
  • Add cargo-deny to CI here in order to ban multiple versions of opentelemetry, as we do in Janus

I'm going to read through the opentelemetry-rust changelogs and get started on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant