From 18ce8efdcf6b8c940d5d6415c7bd04d0cab51e4c Mon Sep 17 00:00:00 2001
From: David Cook <dcook@divviup.org>
Date: Fri, 13 Oct 2023 16:41:51 -0500
Subject: [PATCH] Print output when `kind create cluster` fails (#2126)

---
 core/src/test_util/kubernetes.rs | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/core/src/test_util/kubernetes.rs b/core/src/test_util/kubernetes.rs
index fafbc79e2..49dfd937b 100644
--- a/core/src/test_util/kubernetes.rs
+++ b/core/src/test_util/kubernetes.rs
@@ -181,7 +181,7 @@ impl EphemeralCluster {
         // lockstep with the version of kind installed by the ci-build workflow.
         // https://github.com/kubernetes-sigs/kind/releases/tag/v0.17.0
         // https://cloud.google.com/kubernetes-engine/docs/release-notes#regular-channel
-        assert!(Command::new("kind")
+        let output = Command::new("kind")
             .args([
                 "create",
                 "cluster",
@@ -194,11 +194,16 @@ impl EphemeralCluster {
                  577c630ce8e509131eab1aea12c022190978dd2f745aac5eb1fe65c0807eb315",
             ])
             .stdin(Stdio::null())
-            .stdout(Stdio::null())
-            .stderr(Stdio::null())
-            .status()
-            .unwrap()
-            .success());
+            .stdout(Stdio::piped())
+            .stderr(Stdio::piped())
+            .output()
+            .unwrap();
+        assert!(
+            output.status.success(),
+            "`kind create cluster` failed\nstdout: {}\nstderr: {}",
+            String::from_utf8_lossy(&output.stdout),
+            String::from_utf8_lossy(&output.stderr),
+        );
 
         Self {
             // Kind prefixes the cluster name with "kind-" when creating a kubectl context