Skip to content

Commit

Permalink
Change default to 32, add documentation on option
Browse files Browse the repository at this point in the history
  • Loading branch information
inahga committed Jan 22, 2024
1 parent 86e70e2 commit ec1bf58
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion aggregator/src/binaries/aggregator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ pub struct Config {
}

fn default_task_counter_shard_count() -> u64 {
1
32
}

#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
Expand Down
5 changes: 5 additions & 0 deletions docs/samples/advanced_config/aggregator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ max_upload_batch_write_delay_ms: 250
# than the equivalent setting in the collection job driver. (required)
batch_aggregation_shard_count: 32

# Number of sharded database records per task counter. Increasing this value will reduce the amount
# of database contention during report uploads, while increasing the cost of getting task metrics.
# (optional, default: 32)
task_counter_shard_count: 32

# Configuration for the taskprov extension. If enabled, this changes the behavior of the
# aggregator as described in draft-wang-ppm-dap-taskprov. (optional)
taskprov_config:
Expand Down

0 comments on commit ec1bf58

Please sign in to comment.