From ec1bf58f95681a8d06192f7a5b3bef0514d05320 Mon Sep 17 00:00:00 2001 From: Ameer Ghani Date: Mon, 22 Jan 2024 15:29:41 -0500 Subject: [PATCH] Change default to 32, add documentation on option --- aggregator/src/binaries/aggregator.rs | 2 +- docs/samples/advanced_config/aggregator.yaml | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/aggregator/src/binaries/aggregator.rs b/aggregator/src/binaries/aggregator.rs index 535357df8..dc9306612 100644 --- a/aggregator/src/binaries/aggregator.rs +++ b/aggregator/src/binaries/aggregator.rs @@ -373,7 +373,7 @@ pub struct Config { } fn default_task_counter_shard_count() -> u64 { - 1 + 32 } #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] diff --git a/docs/samples/advanced_config/aggregator.yaml b/docs/samples/advanced_config/aggregator.yaml index 41e44fdc4..61ccd51fb 100644 --- a/docs/samples/advanced_config/aggregator.yaml +++ b/docs/samples/advanced_config/aggregator.yaml @@ -97,6 +97,11 @@ max_upload_batch_write_delay_ms: 250 # than the equivalent setting in the collection job driver. (required) batch_aggregation_shard_count: 32 +# Number of sharded database records per task counter. Increasing this value will reduce the amount +# of database contention during report uploads, while increasing the cost of getting task metrics. +# (optional, default: 32) +task_counter_shard_count: 32 + # Configuration for the taskprov extension. If enabled, this changes the behavior of the # aggregator as described in draft-wang-ppm-dap-taskprov. (optional) taskprov_config: