Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on vulnerable time versions #821

Closed
tgeoghegan opened this issue Dec 7, 2022 · 1 comment
Closed

Remove dependency on vulnerable time versions #821

tgeoghegan opened this issue Dec 7, 2022 · 1 comment

Comments

@tgeoghegan
Copy link
Contributor

We got a security advisory on the time crate: https://github.com/divviup/janus/security/dependabot/9

We pull in the vulnerable version via chrono 0.4.23. Even if we turn off the oldtime feature, other things in our tree depend on chrono and use that feature. I think the way forward is to wait for a chrono release that doesn't depend on time. Fortunately, this is already the case in their upcoming 0.5 release, but I don't know when that will come out.

In the meantime, the chrono maintainers assure us that chrono doesn't use the vulnerable APIs from time, so I don't think we need to do anything.

@divergentdave
Copy link
Collaborator

Done in #1917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants