Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place pack update could leave pack in an invalid state #40

Open
mgziminsky opened this issue Feb 2, 2019 · 0 comments
Open

In-place pack update could leave pack in an invalid state #40

mgziminsky opened this issue Feb 2, 2019 · 0 comments

Comments

@mgziminsky
Copy link
Contributor

When updating an existing pack installation by providing a new URL, the new pack is unzipped directly over the existing installation without first cleaning up the contents of the previous pack. This can result in multiple versions of mods, or other files, from the overrides folder being installed.

To avoid this, a simple solution would be to iterate the contents of the previous pack.zip and remove them from the installation before unpacking the new one. This would account for any changes to the new pack while preserving most other modifications made by the user or MC.

A more robust solution, possibly dealing user changes to the manifest or config probably falls under #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant