Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIV for select box not terminated #156

Closed
dpjanes opened this issue Feb 7, 2024 · 3 comments
Closed

DIV for select box not terminated #156

dpjanes opened this issue Feb 7, 2024 · 3 comments

Comments

@dpjanes
Copy link

dpjanes commented Feb 7, 2024

In templates/tailwind/field.html none of the divs are terminated (for release 1.0.1),

I think there's some mismatch between how you are doing it in the layout folder and in this template - I suspect it makes more sense to move all the closing DIVs back up to this file. In the select.html there is no </div> whereas I think in the radio and checkboxes there are.

@dpjanes dpjanes changed the title DIV for select box not terminate DIV for select box not terminated Feb 7, 2024
@dpjanes
Copy link
Author

dpjanes commented Feb 7, 2024

Basically at this point, crispy-tailwind will not work for <select> any more! So pretty serious.

@justinmayer
Copy link
Contributor

Hey David. I can't test this right now, but if this is indeed an issue, then I am fairly certain that it is a duplicate of #153, so let's continue the discussion there.

As an aside, it's always helpful to check open PRs before filing new issues. Thanks! 😊

@dpjanes
Copy link
Author

dpjanes commented Feb 7, 2024

My apologies, I did look but obviously I am blind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants