Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on_disconnect & on_reconnect no longer supported in PubSub #406

Open
justinttl opened this issue Jan 16, 2025 · 2 comments
Open

on_disconnect & on_reconnect no longer supported in PubSub #406

justinttl opened this issue Jan 16, 2025 · 2 comments

Comments

@justinttl
Copy link

It looks like since #326, on_disconnect and on_reconnect are no longer used/ supported in the pubsub implementation. Should we remove the documentation and API around them?
@carltongibson
Copy link
Member

Hi @justinttl thanks. From the description I'm going to say Yes. I need to look at the code to verify, but if you'd like to work on a PR that would be great. 🎁

@justinttl
Copy link
Author

Sure, I can throw together the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carltongibson @justinttl