-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LimitedStream benchmark #57
Comments
#58, in this PR I have added the benchmark based on the benchmarks (here)[https://code.djangoproject.com/attachment/ticket/33865/bench_limitedstream.py], and the results, were as follows
At first, I had benchmarked all the methods together but I split them into separate methods, but still, the results mentioned in the (ticket)[https://code.djangoproject.com/ticket/33865#no1] differed from what I got, Are there any changes that I need to make to the benchmark? |
Hey @ngnpope — Hoping this is of interest to you! 🙂 @deepakdinesh1123 is working to push forward the work @smithdc1 began to use ASV to regularly run benchmarks on Django. Seeing your PR on I don't know if there's enough info (README etc.) for you to have a proper investigation here yet... 😬 but I thought I'd give you a ping. (@deepakdinesh1123 I have a bit of admin for next week to do this morning, then I'll sit down with this again. Thanks! 👍) |
Thanks @carltongibson. I'm actually trying to start writing these benchmarks for optimisations with this effort in mind. Looking forward to seeing this realised 👏🏻 |
Hi @deepakdinesh1123 @smithdc1.
Have a look at the ticket here: https://code.djangoproject.com/ticket/33865
There's a proposal to optimise
LimitedStream
(which wraps the WSGI request body input stream to ensure we can't read into other requests...).It might be nice to quickly add a benchmark for it, and then be able to say, "Look here's
main
, and here's the PR".Are we there yet?
What do you think?
The text was updated successfully, but these errors were encountered: