Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ids to "Local Django Communities" page #1474

Closed
hmatsuuchi opened this issue Feb 5, 2024 · 2 comments · Fixed by #1475
Closed

Add ids to "Local Django Communities" page #1474

hmatsuuchi opened this issue Feb 5, 2024 · 2 comments · Fixed by #1475

Comments

@hmatsuuchi
Copy link

hmatsuuchi commented Feb 5, 2024 •
edited
Loading

Summary:
Anchor tag link list is not working due to lack of corresponding ids in elements

Page:
https://www.djangoproject.com/community/local/

Code to fix:
https://github.com/django/djangoproject.com/blob/dfa7429ec929c1b5985782c17008cbb5854649f8/djangoproject/templates/aggregator/local-django-community.html

How to fix:
Change this [line: 20]: <div class="section">
to this: <div id="{{ local_django_community.grouper.title }}-meetups" class="section">
@prabs222 prabs222 mentioned this issue Feb 8, 2024
Merged
@prabs222
Copy link
Contributor

prabs222 commented Feb 8, 2024

I have opened a PR #1475, which fixes this issue.

In addition to the line mentioned there were two other lines where either id was missing or was incorrect

@hmatsuuchi
Copy link
Author

Thank you for taking care of that! I'll go ahead and close the issue. @prabs222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1474 Fixed links to subsections in the Local Django Communities page prabs222/djangoproject.com
2 participants
@hmatsuuchi @prabs222