Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1724 -- Renamed "patch" to "pull request" #1729

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmispelon
Copy link
Member

This follows Django ticket # 35894

@bmispelon
Copy link
Member Author

@sarahboyce Are you OK with those new names?

  • Patches ➡️ Pull requests (category title)
  • Patches needing review ➡️ PRs needing review
  • Doc. patches needing review ➡️ Doc. PRs needing review

Here is how it looks like:
Screenshot 2024-11-09 at 23-37-17 Development dashboard Django

@bmispelon bmispelon force-pushed the issue1724/dashboard-rename-patch branch from 4d77309 to 257fda8 Compare November 11, 2024 12:30
@sarahboyce
Copy link
Contributor

Patches ➡️ Pull requests (category title)

Yes, but can we move "Easy ticket" somewhere else? Maybe into "Accepted tickets by type"?

Patches needing review ➡️ PRs needing review
Doc. patches needing review ➡️ Doc. PRs needing review

Wordy but "Tickets with PRs needing review" would be more accurate (and "Doc. tickets with PRs needing review")

@bmispelon
Copy link
Member Author

Yes, but can we move "Easy ticket" somewhere else? Maybe into "Accepted tickets by type"?

Good idea, added 👍🏻 (this is something that can be done via the admin by the way)

Wordy but "Tickets with PRs needing review" would be more accurate (and "Doc. tickets with PRs needing review")

It does stretch the boxes a little bit, but I don't think it's so bad:
Screenshot 2024-11-13 at 20-00-12 Development dashboard Django

This follows Django ticket # 35894
@bmispelon bmispelon force-pushed the issue1724/dashboard-rename-patch branch from 257fda8 to 8b8750f Compare November 13, 2024 19:04
@sarahboyce
Copy link
Contributor

sarahboyce commented Nov 13, 2024

I don't mind the stretch at all 😁
"PRs to review with tickets" and "Ticketed PRs to review" is the shortest I can think of if we want to make them shorter (but saves only a handful of characters)

@bmispelon
Copy link
Member Author

I don't mind the stretch at all 😁 "PRs to review with tickets" and "Ticketed PRs to review" is the shortest I can think of if we want to make them shorter (but saves only a handful of characters)

You look at the dashboard more than me (not a high bar 😁 ), so I defer to your opinion on this.

@sarahboyce
Copy link
Contributor

@nessita are you happy with the naming below?

Screenshot 2024-11-13 at 20-00-12 Development dashboard Django

Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all the cases where pull request is used I think "patch" is an more correct term. What we truly review is a patch (sometimes is a PR, something is a diff file...). But we grab a diff describing a code change and comment on it.

What's the goal of changing the term Patches in the dashboard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants