Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flood weighting for locations implemented double? #110

Open
djgroen opened this issue Oct 17, 2024 · 1 comment
Open

Flood weighting for locations implemented double? #110

djgroen opened this issue Oct 17, 2024 · 1 comment
Assignees
@alirezajahani60 @lauraharbach
Labels
bug

Comments

@djgroen
Copy link
Owner

djgroen commented Oct 17, 2024 •
edited
Loading

Hi both,

I just noticed that the applied flood weighting appears to be applied to Locations twice?

There appears to be an implementation in UpdateLocationScore() in scoring.py, which is used to calculate the base end point score used in getEndPointScore() in moving.py. However, after that base end point score is retrieved I see very similar code being applied to multiply that score with the same factors once more in getEndPointScore().

Could you perhaps double check this? I would recommend removing the implementation in getEndPointScore if it is a proper duplication....

(this might also explain why the DFlee test has been failing occasionally (see #107).
@djgroen djgroen added the bug label Oct 17, 2024
@djgroen
Copy link
Owner Author

djgroen commented Nov 7, 2024

@lauraharbach I think this has been resolved? Can I close this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alirezajahani60 alirezajahani60

@lauraharbach lauraharbach

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@djgroen @alirezajahani60 @lauraharbach