Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFlee feature porting #81

Open
6 of 7 tasks
djgroen opened this issue Aug 24, 2023 · 5 comments
Open
6 of 7 tasks

DFlee feature porting #81

djgroen opened this issue Aug 24, 2023 · 5 comments
Assignees
Labels
columbia Tasks to support Team Columbia dflee Issues and fixes related to DFlee enhancement iom
Milestone

Comments

@djgroen
Copy link
Owner

djgroen commented Aug 24, 2023

  • Add support for flood-driven spawning settings in SimulationSettings.
  • Add support for flood level rule settings in SimulationSettings.
  • Add support for reading in flood_level.csv.
  • Conversion of flood level data structure in InputGeography to Location attributes (update per time step).
  • Implementation of flood-driven spawning in spawning.py

And then:

  • Enforcement of flooding rules in moving.py, after previous steps are completed.
  • Update of documentation to describe flooding model feature.
@djgroen
Copy link
Owner Author

djgroen commented Aug 26, 2023

The flood_level data structure is now in place, and properly being read in and stored on the locations.

@alirezajahani60 I do not have dynamic flood level properties for link attributes yet. Is this something you want to have present in the first version of DFlee, or would you prefer to have an early test version with only location flood levels for now?

Adding dynamic flood level properties for links could take a few days of development effort, i.e. ~2 weeks delay in actually code delivery time.

@djgroen
Copy link
Owner Author

djgroen commented Aug 26, 2023

Btw. take special note of https://github.com/djgroen/flee/blob/master/tests/dflee.py

This is what I initially wanted you to write, but I put it together myself now. It will be handy for you, as you can see how the DFlee functionality is called and used.

The idea is of course that DFlee will not require a separate runscript. Simple changes in simsetting.yml should suffice for it.

@djgroen djgroen added enhancement columbia Tasks to support Team Columbia iom labels Aug 26, 2023
@alirezajahani60
Copy link
Collaborator

@djgroen Thanks Derek. I think for the beginning we can have at location level and add dynamic flood level for links later.

I still need help to understand the relationship between the runscript and test_dflee.py! If I understand correctly, by changing the simsetting.yml, I can simply execute the runscript and the test_dflee.py, which is in flee directory would read the input files and the flee.py does the rest of simulation?

@djgroen
Copy link
Owner Author

djgroen commented Aug 26, 2023

@alirezajahani60 Partially correct! Let me elaborate :)

"If I understand correctly, by changing the simsetting.yml, I can simply execute the runscript"

  • Yes, that is correct. That is how you will be able to use it :).

"and the test_dflee.py, which is in flee directory would read the input files and the flee.py does the rest of simulation?""

@djgroen
Copy link
Owner Author

djgroen commented Aug 27, 2023

Documentation is written but not pushed to the repo yet. I will leave this ticket open during the testing phase.

@alirezajahani60 alirezajahani60 added the dflee Issues and fixes related to DFlee label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
columbia Tasks to support Team Columbia dflee Issues and fixes related to DFlee enhancement iom
Projects
None yet
Development

No branches or pull requests

3 participants