-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/default co2 rf method #49
Conversation
Any default configuration settings can be included within read_config DEFAULT_CONFIG. If setting not defined in config, it will be added from there.
Any default configuration settings can be included within read_config DEFAULT_CONFIG. If setting not defined in config, it will be added from there.
…r-pa/oac into feature/default-co2-rf-method
Update TestCheckConfig. Add TestGetKeysValues, TestAddDefaultConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few minor comments. Whilst doing this review with a clean installation of OpenAirClim, I noticed that a number of the tests did not pass, which I now found out to be because they require create_test_files.py
to have been run. I opened issue #50 to address this.
Update of example.toml, CONFIG_TEMPLATE in read_config.py and tests/read_config_test.py Update of openairclim.rst for automatic generation of API doc for module calc_cont.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Before you get started
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Note
Type of change
How has this been tested?
Please describe the software tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test configuration:
Checklist