New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegexValidator.forURL is overly restrictive #66

Open

VirtualTim opened this issue Mar 1, 2023 · 0 comments

VirtualTim commented Mar 1, 2023

Regex is here:

FormsFX/formsfx-core/src/main/java/com/dlsc/formsfx/model/validators/RegexValidator.java

Line 86 in 9d12251

    
           return new RegexValidator("(https?:\\/\\/(?:www\\.|(?!www))[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\\.[^\\s]{2,}|www\\.[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\\.[^\\s]{2,}|https?:\\/\\/(?:www\\.|(?!www))[a-zA-Z0-9]\\.[^\\s]{2,}|www\\.[a-zA-Z0-9]\\.[^\\s]{2,})", errorMessage);

Basically this marks urls like https://localhost:80/ as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment