We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello!
A implementation like this may pass the original test data.
def gradient(self, out_grad, node): return Tensor(array_api.ones_like(out_grad))
But when given 2 matrix , it fail.
So I sincerely propose to add this sample to function summation_backward() in test_autograd_hw.py of hw1
summation_backward()
test_autograd_hw.py
gradient_check(lambda A,C : ndl.summation(ndl.reshape(A,shape=(10,5))+C, axes=None), ndl.Tensor(np.random.randn(50)), ndl.Tensor(np.random.randn(10,5)), backward=True)
this originates from the last sample of function test_compute_gradient() with other operations removed.
test_compute_gradient()
I hope this may discover problems earlier to save time. Thanks for your attention.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hello!
A implementation like this may pass the original test data.
But when given 2 matrix , it fail.
So I sincerely propose to add this sample to function
summation_backward()
intest_autograd_hw.py
of hw1this originates from the last sample of function
test_compute_gradient()
with other operations removed.I hope this may discover problems earlier to save time.
Thanks for your attention.
The text was updated successfully, but these errors were encountered: