Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_url function does not recognise urls with localhost #47

Open
fruchtblase opened this issue Mar 10, 2023 · 0 comments
Open

is_url function does not recognise urls with localhost #47

fruchtblase opened this issue Mar 10, 2023 · 0 comments

Comments

@fruchtblase
Copy link

Hello everyone,

thanks for the great package! I stumbled into a little bug (or desired behavior that isn't documented): if you specifiy an url with localhost, you will get an error.

Maybe the regex in the is_url function needs to be refitted? This comparison of url regexes might help https://mathiasbynens.be/demo/url-regex

Cheers!

library(httr)
library(polite)

polite_POST <- politely(httr::POST, verbose=TRUE) 
polite_POST(url = "http://localhost:3001/api/v1/document")

Error: I can't find an argument containing url. Aborting.

polite_0.1.2
httr_1.4.5
R version 4.2.2 (2022-10-31 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19045)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant