Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use customized urlRequestConfiguration.cachePolicy in requesting #177

Open
torufuruya opened this issue Sep 1, 2023 · 0 comments · May be fixed by #178
Open

Use customized urlRequestConfiguration.cachePolicy in requesting #177

torufuruya opened this issue Sep 1, 2023 · 0 comments · May be fixed by #178
Labels
enhancement New feature or request

Comments

@torufuruya
Copy link

torufuruya commented Sep 1, 2023

Is your feature request related to a problem? Please describe.

I'm observing some of my image URLs are not fetched from the remote source once 404 responses for that were cached (Is it expected behavior in the first palce?). So I tried to change urlRequestConfiguration.cachePolicy but it seems only urlRequestConfiguration.allHTTPHeaderFields is used.

Describe the solution you'd like

If my understanding is correct, it can be done by setting the download.urlRequestConfiguration.cachePolicy on making the URLSessionTask in URLSessionCoordinator.
https://github.com/dmytro-anokhin/url-image/blob/main/Dependencies/Sources/DownloadManager/URLSession/URLSessionCoordinator.swift#L166-L167

Describe alternatives you've considered

N/A

Additional context

N/A

@torufuruya torufuruya added the enhancement New feature or request label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant