Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed, but needs release 7.0.1 or later - Tag validation fails on registries with :PORT specified (localhost:5000/example:latest) #3240

Closed
consideRatio opened this issue Mar 25, 2024 · 1 comment

Comments

@consideRatio
Copy link

consideRatio commented Mar 25, 2024

#3191 introduces a regex to validate what valid tags are. This led to a validation failure for localhost:5000/example:latest, and according to the description in https://docs.docker.com/reference/cli/docker/image/tag/#description should be allowed. It has practically worked before as well, so I think this is too narrow validation.

There is an example in docker docs that also fails validation: myregistryhost:5000/fedora/httpd:version1.0

image

@alexrashed
Copy link

Chiming in here from the side: This was discussed in localstack/localstack#9864. I think this issue has already been fixed with #3196, but unfortunately there hasn't been a release containing the fix yet.

@consideRatio consideRatio changed the title Tag validation fails on registries with :PORT specified (localhost:5000/example:latest) Fixed, but not released - Tag validation fails on registries with :PORT specified (localhost:5000/example:latest) Mar 25, 2024
@consideRatio consideRatio changed the title Fixed, but not released - Tag validation fails on registries with :PORT specified (localhost:5000/example:latest) Fixed, but needs release 7.0.1 or later - Tag validation fails on registries with :PORT specified (localhost:5000/example:latest) Mar 25, 2024
yuvipanda added a commit to yuvipanda/repo2docker-action that referenced this issue Mar 26, 2024
Brings in a fix for docker/docker-py#3240,
until docker-py is released upstream.

Ref jupyterhub#117
yuvipanda added a commit to yuvipanda/repo2docker-action that referenced this issue Mar 26, 2024
Brings in a fix for docker/docker-py#3240,
until docker-py is released upstream.

Ref jupyterhub#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants