-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed, but needs release 7.0.1 or later - Tag validation fails on registries with :PORT
specified (localhost:5000/example:latest
)
#3240
Comments
This was referenced Mar 25, 2024
Chiming in here from the side: This was discussed in localstack/localstack#9864. I think this issue has already been fixed with #3196, but unfortunately there hasn't been a release containing the fix yet. |
consideRatio
changed the title
Tag validation fails on registries with
Fixed, but not released - Tag validation fails on registries with Mar 25, 2024
:PORT
specified (localhost:5000/example:latest
):PORT
specified (localhost:5000/example:latest
)
consideRatio
changed the title
Fixed, but not released - Tag validation fails on registries with
Fixed, but needs release 7.0.1 or later - Tag validation fails on registries with Mar 25, 2024
:PORT
specified (localhost:5000/example:latest
):PORT
specified (localhost:5000/example:latest
)
yuvipanda
added a commit
to yuvipanda/repo2docker-action
that referenced
this issue
Mar 26, 2024
Brings in a fix for docker/docker-py#3240, until docker-py is released upstream. Ref jupyterhub#117
yuvipanda
added a commit
to yuvipanda/repo2docker-action
that referenced
this issue
Mar 26, 2024
Brings in a fix for docker/docker-py#3240, until docker-py is released upstream. Ref jupyterhub#117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#3191 introduces a regex to validate what valid tags are. This led to a validation failure for
localhost:5000/example:latest
, and according to the description in https://docs.docker.com/reference/cli/docker/image/tag/#description should be allowed. It has practically worked before as well, so I think this is too narrow validation.There is an example in docker docs that also fails validation:
myregistryhost:5000/fedora/httpd:version1.0
The text was updated successfully, but these errors were encountered: