Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo #21688

Open
1 task done
setjava opened this issue Dec 26, 2024 · 4 comments
Open
1 task done

typo #21688

setjava opened this issue Dec 26, 2024 · 4 comments
Assignees
@12rashic
Labels
status/triage Needs triage

Comments

@setjava
Copy link

setjava commented Dec 26, 2024

Is this a docs issue?

  • My issue is about the documentation content or website

Type of issue

Information is incorrect

Description

Should be private bind propagation

https://docs.docker.com/engine/storage/volumes/#when-to-use-volumes

Location

https://docs.docker.com/engine/storage/volumes/

Suggestion

No response
@setjava setjava added the status/triage Needs triage label Dec 26, 2024
@thaJeztah
Copy link
Member

Volumes use rprivate bind propagation, and bind propagation isn't configurable for volumes.

Thanks for reporting. It's not a typo; the "r" stands for recursive, and rprivate is a valid mode; https://docs.docker.com/engine/storage/bind-mounts/#configure-bind-propagation

Perhaps the section should refer to those options (or spell out "(recursive private)")

any thoughts @dvdksn ?

@12rashic
Copy link
Contributor

12rashic commented Jan 2, 2025

I can work on this issue @thaJeztah

@dvdksn
Copy link
Contributor

dvdksn commented Jan 3, 2025

@12rashic thanks, feel free to open a PR

@12rashic 12rashic mentioned this issue Jan 3, 2025
Merged
3 tasks
@12rashic
Copy link
Contributor

12rashic commented Jan 3, 2025 •
edited
Loading

Can you please review this PR - #21711
@dvdksn / @thaJeztah

aevesdocker added a commit that referenced this issue Feb 5, 2025
@12rashic @aevesdocker @dvdksn
fix: clarified rprivate by adding spell out recursive private in volu…
6c679a6 
…mes.md (#21711)

## Description

<!-- Tell us what you did and why -->
To avoid confusion of rprivate provided fix: clarified rprivate by
adding spell out recursive private in volumes.md

## Related issues or tickets
#21688

<!-- Related issues, pull requests, or Jira tickets --> 
#21688

## Reviews

<!-- Notes for reviewers here -->
<!-- List applicable reviews (optionally @tag reviewers) -->

- [ ] Technical review
- [ ] Editorial review
- [ ] Product review

---------

Signed-off-by: Rashi Chaubal <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: David Karlsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@12rashic 12rashic

Labels
status/triage Needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thaJeztah @dvdksn @setjava @12rashic