Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting http.DefaultClient in store/consul/consul.go causes failure in consul API 0.8.1, Go 1.8.1 #159

Open
ebudan opened this issue Apr 26, 2017 · 0 comments

Comments

@ebudan
Copy link

ebudan commented Apr 26, 2017

Hello

When working against version 0.8.1 of consul-api under Go 1.8.1, the following line
causes consul-api to fail (interface conversion of nil):
https://github.com/docker/libkv/blob/master/store/consul/consul.go#L75

Commenting this line out lets consul-api proceed with its own default client initialization, which would seem to be enough for the purposes here. (I have't verified that TLS will work, however.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant