Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible data race in AddStore() #206

Open
kmulvey opened this issue May 9, 2019 · 0 comments
Open

possible data race in AddStore() #206

kmulvey opened this issue May 9, 2019 · 0 comments

Comments

@kmulvey
Copy link

kmulvey commented May 9, 2019

Im getting a race when running two tests in parallel that both create clients. Shouldn't there be a lock around that initializers map?

==================
WARNING: DATA RACE
Write at 0x00c00008b198 by goroutine 7:
  github.com/kmulvey/scratch/election.TestJoinElection()
      /opt/code/go/pkg/mod/github.com/docker/[email protected]/libkv.go:39 +0xfd
  testing.tRunner()
      /usr/lib/golang/src/testing/testing.go:865 +0x163

Previous write at 0x00c00008b198 by goroutine 8:
  github.com/kmulvey/scratch/election.TestJoinElectionFail()
      /opt/code/go/pkg/mod/github.com/docker/[email protected]/libkv.go:39 +0xf7
  testing.tRunner()
      /usr/lib/golang/src/testing/testing.go:865 +0x163

libkv/libkv.go

Line 39 in 4589771

initializers[store] = init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmulvey