Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error out on no devices in dir #6

Merged
merged 3 commits into from
May 22, 2024
Merged

Error out on no devices in dir #6

merged 3 commits into from
May 22, 2024

Conversation

jonnystoten
Copy link
Contributor

No description provided.

@jonnystoten jonnystoten requested a review from a team as a code owner April 30, 2024 14:24
whalelines
whalelines reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

tools/key-verification/main.go Show resolved Hide resolved
@jonnystoten
Write errors to stderr and exit on fatal error
118ddd0
@jonnystoten
Filter out non-directories up front
80fa7fa 
This way we error when given a path to a dir which contains files but
doesn't contain directories.
whalelines
whalelines approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnystoten jonnystoten merged commit ba8ad33 into main May 22, 2024
2 checks passed
@jonnystoten jonnystoten deleted the no-devices branch May 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whalelines whalelines whalelines approved these changes

@mrjoelkamp mrjoelkamp mrjoelkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonnystoten @mrjoelkamp @whalelines