Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nose from install_requires #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joekohlsdorf
Copy link

@joekohlsdorf joekohlsdorf commented Mar 22, 2022

Nose is a test requirement, it is not necessary for users to install it.
It is listed in test-requirements.txt so removing it from install_requires should not make a difference for tests. I have reviewed the code and have not found any use of nose at runtime.

Problem description:

  • The internal test requirement nose is installed when a user installs the client for runtime use.

Reproduction steps:

# docker run -it --rm --entrypoint=/bin/bash python
# pip install docusign-esign==3.14.0

Observed result:

  • After running the command, the nose package is installed:
# pip freeze | grep nose
nose==1.3.7

Expected result:

  • The nose package is not installed for runtime use of the docusign-esign package.

joekohlsdorf and others added 2 commits March 22, 2022 17:57
Nose is a test requirement, it is not necessary for users to install it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant