-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URI.escape obsolete warning on Ruby 2.7+ #45
Comments
Note: it would not be a simple drop-in replacement. CGI.escape is meant for encoding query params only, encodes spaces in the wrong format ( One option, would be to add the > Addressable::URI.encode("https:://foo.com/bar?query=Programming Ruby: The Pragmatic Programmer's Guide")
=> "https:://foo.com/bar?query=Programming%20Ruby:%20%20The%20Pragmatic%20Programmer's%20Guide" |
Thank you for the bug report. I have submitted Jira DCM-4337 for our engineering team to evaluate the issue. Thank you, |
If the path to fix this is to add the |
👋 @LarryKlugerDS has any progress been made on this? If not, I can take a look and open a PR in the coming days. |
Any update on having this resolved? We are working on an upgrade to ruby 3, but this is a blocker. |
Looks like the sendinblue gem has been updated. What is the status of Docusign therefore being updated? |
We have released a new RC version with a fix, please give it a try and let us know if you see any issues. Thanks and sorry we couldn't get the fix out sooner. V2.1 - https://rubygems.org/gems/docusign_esign/versions/3.8.0.rc1 |
V2 - https://rubygems.org/gems/docusign_esign/versions/2.8.0.rc1 worked for me! Thank you!!! |
V2.1 - https://rubygems.org/gems/docusign_esign/versions/3.8.0.rc1 we still have the warnings |
on Ruby 3, |
version 2.9 works with Ruby3 |
On
|
Did the RC fix for 3.8.0 not get retained in 3.10.0 or 3.10.0.RC? I tried both of those versions and still get the URI warning. |
I guess that fix never made it into main branch. I see the Open PR that has a test failure. |
Looks like this is fixed in the 3.12 release. No more warnings for me. |
Agreed... upgraded and the warning is now gone! |
An annoying warning is raised by
URI.encode
(which is an alias ofURI.escape
) on Ruby 2.7+Here is an article explaining why. TL;DR it's been obsolete for 10 years now but since Ruby 2.7, the warning is now displayed even when not running in verbose mode.
It's pretty annoying as it can quickly ruin one's logs.
As suggested per the stdlib doc, we could use
CGI.escape
instead.The text was updated successfully, but these errors were encountered: