Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require engines to pass clones of messages to handlers. #165

Open
jmalloc opened this issue Aug 7, 2024 · 0 comments
Open

Require engines to pass clones of messages to handlers. #165

jmalloc opened this issue Aug 7, 2024 · 0 comments
Labels
needs adr The changes discussed require an ADR
Milestone

Comments

@jmalloc
Copy link
Member

jmalloc commented Aug 7, 2024

In a nutshell, to prevent problems with memory being shared across messages and within aggregate/process state, we could require any message value passed to a handler to be a clone of the message such that we can say that the handler "owns" the memory used by values within the message.

This would apply regardless of which method on the handler is called, e.g. RouteCommandToInstance, HandleCommand, TimeoutHint, etc.

@jmalloc jmalloc moved this to Proposed in Dogma General Availability Aug 7, 2024
@jmalloc jmalloc added the needs adr The changes discussed require an ADR label Aug 7, 2024
@jmalloc jmalloc added this to the 1.0.0 milestone Aug 7, 2024
@jmalloc jmalloc added the undecided Further discussion is required to how (or whether) to proceed label Aug 7, 2024
@jmalloc jmalloc removed the undecided Further discussion is required to how (or whether) to proceed label Aug 22, 2024
@jmalloc jmalloc moved this from Proposed to Accepted in Dogma General Availability Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs adr The changes discussed require an ADR
Projects
Development

No branches or pull requests

1 participant