Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert persistence items and meta-data, etc to protobuf messages. #180

Open
jmalloc opened this issue Apr 19, 2020 · 1 comment
Open

Convert persistence items and meta-data, etc to protobuf messages. #180

jmalloc opened this issue Apr 19, 2020 · 1 comment
Labels
persistence Relates to the persistence layer

Comments

@jmalloc
Copy link
Member

jmalloc commented Apr 19, 2020

  • queuestore.Item
  • eventstore.Item
  • aggregatestore.MetaData

These types are all intended for persistence and contain primitive types. If we convert them to protocol buffers messages it makes them a lot easier to persist in new provider implementations, and we can do away with the boltdb/internal/pb package which has cut-down PB representations of these types already.

@jmalloc jmalloc added this to the 1.0.0 - Production milestone Apr 19, 2020
@jmalloc
Copy link
Member Author

jmalloc commented Apr 20, 2020

Just thought I'd point out that the types used for BoltDB now are cut down from the originals, choosing not to re-persisted data that is already used as bucket-keys, for example. This doesn't necessarily stop us from doing this task, those fields could just be zeroed out to avoid duplicating them in the datastore.

@jmalloc jmalloc added the persistence Relates to the persistence layer label Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
persistence Relates to the persistence layer
Projects
None yet
Development

No branches or pull requests

1 participant