Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deps config property #152

Open
rorticus opened this issue Nov 10, 2017 · 3 comments
Open

Add support for deps config property #152

rorticus opened this issue Nov 10, 2017 · 3 comments

Comments

@rorticus
Copy link
Contributor

The dojo1 loader supported the deps/callback property in the config, http://dojotoolkit.org/reference-guide/1.10/loader/amd.html#loader-amd .

This property would cause the loader to require deps modules after it's loaded.

@kitsonk
Copy link
Member

kitsonk commented Nov 29, 2017

I would be reticent to introduce anything that isn't covered by the Common AMD Configuration. If this doesn't satisfy it, I would say we should consider how RequireJS accomplishes it before actually looking at behaviour of the Dojo 1 loader.

What use case is driving this need?

@matt-gadd
Copy link
Contributor

@kitsonk requirejs supports both deps and a callback, these are both useful for pre-setup dependencies

@kitsonk
Copy link
Member

kitsonk commented Feb 16, 2018

if requirejs supports them, I would say they are part of the psuedo standard then and I guess it gives it an ability to turn the require API signature into a single options bag... I wonder why it wasn't part of the common config as it seems to make to make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants