-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DokanOperations and mirror rename fileName #290
Comments
This comes from the Kernel where all variables holding the path of files are named |
i can understand the choice of keeping that way, but i still advocate for changing it, this library is for .net where a path and a filename have a different meaning, if you don't, no hard feelings 🤣 |
That's a valid reason! |
so in our implementation, we renamed all the variables coming from dokan.net named |
I am less a fan of kernelpath as it could be taken as another Microsoft format and it is not DotNet style. |
The variable named fileName in all the methods exposed in IDokanOperations should have been path, fileName is as confusing as it could be.
The text was updated successfully, but these errors were encountered: