Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting an error message when running the sample commands #41

Open
kourgeorge opened this issue Aug 19, 2018 · 2 comments
Open

Getting an error message when running the sample commands #41

kourgeorge opened this issue Aug 19, 2018 · 2 comments
Assignees

Comments

@kourgeorge
Copy link

kourgeorge commented Aug 19, 2018

I have downloaded, built and installed the latest version as instructed on a ubuntu.

I've tried to run the example :

musly -N
musly -x mp3 -a /path/to/my/music
musly -p input.mp3

Creating a new collection and analyzing a directory worked fine (first and second command).
But the last command did not work.
I get the following output:

Installed audio decoder: libav
Reading collection file: collection.musly
Loaded 29 musly tracks to memory.
Initializing jukebox...
File not found in collection! Aborting.
@leihuayi
Copy link

leihuayi commented Sep 14, 2018

I had the same issue, but I think I found the problem.
When you run musly -l are the paths of your files correct ?
If you use linux tab while writing the directory name in musly -a /path/to/dir a final "/" will be added turning it into path/to/dir/. Then musly saves the files as /path/to/dir//track01.mp3, /path/to/dir//track02.wav, etc. Therefore it doesn't find the file /path/to/dir/track01.mp3 afterwards.

It should be a simple fix in the main.cpp code, but meanwhile just avoid adding a final "/" to your path.

@f0k
Copy link
Collaborator

f0k commented Oct 18, 2018

@kourgeorge: Nice catch. It seems my colleague has forgotten to implement the feature for comparing to out-of-collection files and I never noticed! The original documentation says it is possible:
https://github.com/dominikschnitzer/musly/blob/594141d/musly/programoptions.cpp#L177-L179
But the implementation did not permit it:
https://github.com/dominikschnitzer/musly/blob/594141d/musly/main.cpp#L686
I will assign this to me, but cannot work on this too quickly. A pull request is welcome.

@f0k f0k self-assigned this Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants