all-the-icons--icon-info-for-buffer returns wrong icons

[seagle0128]

all-the-icons.el/all-the-icons.el

Line 785 in f996faf

(defun all-the-icons--icon-info-for-buffer (&optional f)

Hi, Thanks for this great package!

I found all-the-icons-icon-for-buffer returns wrong icons some times, then I reviewed the codes, and found the logic in all-the-icons--icon-info-for-buffer may be incorrect. I don't understand why it calls all-the-icons-auto-mode-match?. I think it should check all-the-icons-mode-icon-alist as you mentioned in #15 (comment).

Besides, IMO all-the-icons-mode-icon-alist should not be ###autoload since it's an internal function, while should add to all-the-icons-icon-for-buffer and all-the-icons-icon-for-dir.

[wyuenho]

Yep, thid function is a bit of a pain, care to open a PR?

[seagle0128]

@wyuenho Hmm... I tried some solutions locally and understood these codes completely. It seems a trade-off, but the most of the icons are appropriate. I'd like close it for now, and will reopen and submit a PR if I found a better solution. Thanks!

[LukeXuan]

Hello, I would like to revive this issue as I'm quite bothered by this bug. In particular, I'm using both Coq and Verilog languages and both of them share the same extension ".v".

I believe the fix to the problem is to not check the major-mode against the auto-mode-alist, but rather some other association list generated from the all-the-icons-extension-icon-alist.

[bestlem]

Also see #275