Merge pull request #1 from tdesveaux/tds/react-base/fix_end_build_crash

www-react: Fix crash on build ending
dontnod · Oct 26, 2023 · c78ceb5 · c78ceb5
2 parents 3bc2181 + dcbeb7f
commit c78ceb5
Show file tree

Hide file tree

Showing 3 changed files with 99 additions and 6 deletions.
diff --git a/www/react-base/src/components/RawData/RawData.test.tsx b/www/react-base/src/components/RawData/RawData.test.tsx
@@ -49,6 +49,8 @@ describe('RawData component', function() {
       float: 123.4,
       boolean: true,
       array: [321, "string", true],
+      null: null,
+      undefined: undefined,
     }
 
     assertRenderSnapshot(obj);
@@ -61,6 +63,8 @@ describe('RawData component', function() {
       float: 123.4,
       boolean: true,
       array: observable([321, "string", true]),
+      null: null,
+      undefined: undefined,
     });
 
     assertRenderSnapshot(obj);
@@ -73,6 +77,8 @@ describe('RawData component', function() {
         {int: 123},
         {float: 123.4},
         {boolean: true},
+        {null: null},
+        {undefined: undefined},
       ],
     };
 
@@ -86,6 +92,8 @@ describe('RawData component', function() {
         {int: 123},
         {float: 123.4},
         {boolean: true},
+        {null: null},
+        {undefined: undefined},
       ],
     };
 
@@ -99,6 +107,8 @@ describe('RawData component', function() {
         observable({int: 123}),
         observable({float: 123.4}),
         observable({boolean: true}),
+        observable({null: null}),
+        observable({undefined: undefined}),
       ],
     });
 

diff --git a/www/react-base/src/components/RawData/RawData.tsx b/www/react-base/src/components/RawData/RawData.tsx
@@ -52,25 +52,30 @@ export const RawData = ({data}: RawDataProps) => {
   }
 
   const renderDataElement = (value: any) => {
-    if (!isObjectRaw(value) && !isArrayOfObjectsRaw(value)) {
-      return <dd>{value === null ? "null" : value.toString()}&nbsp;</dd>;
+    if (value === null) {
+      return <dd>{"null"}&nbsp;</dd>;
     }
-    if (isArrayOfObjectsRaw(value)) {
+    else if (value === undefined) {
+      return <dd>{"undefined"}&nbsp;</dd>;
+    }
+    else if (isArrayOfObjectsRaw(value)) {
       return (
         <dd>
           <ArrowExpander isExpanded={isExpanded} setIsExpanded={setIsExpanded}/>
           {isExpanded ? renderArrayElements(value as any[]) : <span>{JSON.stringify(value)}</span>}
         </dd>
       );
     }
-    if (isObjectRaw(value)) {
+    else if (isObjectRaw(value)) {
       return (
         <dd>
           <ArrowExpander isExpanded={isExpanded} setIsExpanded={setIsExpanded}/>
           {isExpanded ? <div><RawData data={value}/></div> : <></>}
         </dd>
       )
     }
+
+    return <dd>{value.toString()}&nbsp;</dd>;
   }
 
   const renderElements = () => {

diff --git a/www/react-base/src/components/RawData/__snapshots__/RawData.test.tsx.snap b/www/react-base/src/components/RawData/__snapshots__/RawData.test.tsx.snap
@@ -32,7 +32,7 @@ exports[`RawData component object with array of objects 1`] = `
         />
       </svg>
       <span>
-        [{"str":"string"},{"int":123},{"float":123.4},{"boolean":true}]
+        [{"str":"string"},{"int":123},{"float":123.4},{"boolean":true},{"null":null},{}]
       </span>
     </dd>
   </div>
@@ -139,6 +139,40 @@ exports[`RawData component object with array of objects expanded 1`] = `
             </div>
           </dl>
         </li>
+        <li>
+          <dl
+            className="dl-horizontal"
+          >
+            <div
+              className="bb-raw-data-key-value"
+            >
+              <dt>
+                null
+              </dt>
+              <dd>
+                null
+                 
+              </dd>
+            </div>
+          </dl>
+        </li>
+        <li>
+          <dl
+            className="dl-horizontal"
+          >
+            <div
+              className="bb-raw-data-key-value"
+            >
+              <dt>
+                undefined
+              </dt>
+              <dd>
+                undefined
+                 
+              </dd>
+            </div>
+          </dl>
+        </li>
       </ul>
     </dd>
   </div>
@@ -204,6 +238,28 @@ exports[`RawData component observable object 1`] = `
        
     </dd>
   </div>
+  <div
+    className="bb-raw-data-key-value"
+  >
+    <dt>
+      null
+    </dt>
+    <dd>
+      null
+       
+    </dd>
+  </div>
+  <div
+    className="bb-raw-data-key-value"
+  >
+    <dt>
+      undefined
+    </dt>
+    <dd>
+      undefined
+       
+    </dd>
+  </div>
 </dl>
 `;
 
@@ -239,7 +295,7 @@ exports[`RawData component observable object with array of objects 1`] = `
         />
       </svg>
       <span>
-        [{"str":"string"},{"int":123},{"float":123.4},{"boolean":true}]
+        [{"str":"string"},{"int":123},{"float":123.4},{"boolean":true},{"null":null},{}]
       </span>
     </dd>
   </div>
@@ -305,5 +361,27 @@ exports[`RawData component simple object 1`] = `
        
     </dd>
   </div>
+  <div
+    className="bb-raw-data-key-value"
+  >
+    <dt>
+      null
+    </dt>
+    <dd>
+      null
+       
+    </dd>
+  </div>
+  <div
+    className="bb-raw-data-key-value"
+  >
+    <dt>
+      undefined
+    </dt>
+    <dd>
+      undefined
+       
+    </dd>
+  </div>
 </dl>
 `;