Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Contentlet: Make our dotAddImage custom plugins for TinyMCE work in Angular #27969

Closed
1 task
Tracked by #25445
rjvelazco opened this issue Mar 14, 2024 · 4 comments · Fixed by #27982, #28065 or #28075
Closed
1 task
Tracked by #25445

Edit Contentlet: Make our dotAddImage custom plugins for TinyMCE work in Angular #27969

rjvelazco opened this issue Mar 14, 2024 · 4 comments · Fixed by #27982, #28065 or #28075
Assignees
@zJaaal @rjvelazco
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 24.04.5 CLI Team : Lunik Triage Type : Task

Comments

@rjvelazco
Copy link
Contributor

rjvelazco commented Mar 14, 2024 •
edited
Loading

Parent Issue

#25445

Task

dotCMS has a custom plugin called dotAddImage which allows user add images coming from dotCMS into their WYSIWYG field. Since we are moving this field from dojo to Angular, we must bring this custom plugin and it should work as expected.

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

  • The dotAddImage plugin should work as expected in the new WYSIWYG field

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

  • Search how to add custom plugins in tinyMCE v6 Angular integration.
  • Check out the dotAddImage plugin and see how it works.

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@rjvelazco rjvelazco changed the title Edit Contentlet: Make our dotimageclipboard custom plugins for TinyMCE work in Angular Edit Contentlet: Make our doteditimage custom plugins for TinyMCE work in Angular Mar 14, 2024
@rjvelazco rjvelazco self-assigned this Mar 14, 2024
@rjvelazco rjvelazco moved this from New to In Progress in dotCMS - Product Planning Mar 14, 2024
@rjvelazco rjvelazco changed the title Edit Contentlet: Make our doteditimage custom plugins for TinyMCE work in Angular Edit Contentlet: Make our dotAddImage custom plugins for TinyMCE work in Angular Mar 14, 2024
@rjvelazco rjvelazco linked a pull request Mar 15, 2024 that will close this issue
feat(Edit Contentlet): Make our dotAddImage custom plugins for TinyMCE work in Angular #27982
Merged
@rjvelazco rjvelazco mentioned this issue Mar 19, 2024
Open
@rjvelazco rjvelazco moved this from In Progress to In Review in dotCMS - Product Planning Mar 22, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Mar 25, 2024
@rjvelazco rjvelazco moved this from Done to Internal QA in dotCMS - Product Planning Mar 25, 2024
@zJaaal zJaaal self-assigned this Mar 25, 2024
@rjvelazco rjvelazco reopened this Mar 25, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Mar 25, 2024
@rjvelazco rjvelazco linked a pull request Mar 25, 2024 that will close this issue
Fix(Edit Contentlet): Make our dotAddImage custom plugins for TinyMCE work in Angular #28065
Merged
@github-project-automation github-project-automation bot moved this from Current Sprint Backlog to Done in dotCMS - Product Planning Mar 25, 2024
@zJaaal zJaaal reopened this Mar 26, 2024
@zJaaal zJaaal moved this from Done to Internal QA in dotCMS - Product Planning Mar 26, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Mar 26, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Mar 26, 2024

Failed IQA

File Asset Images are not getting rendered

Screen.Recording.2024-03-26.at.11.15.59.AM.mov

@fmontes fmontes linked a pull request Mar 26, 2024 that will close this issue
fix(edit-content): Make our dotAddImage custom plugins for TinyMCE work in Angular FILEASSET #27969 #28075
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 26, 2024
@rjvelazco @fmontes
fix(edit-content): Make our dotAddImage custom plugins for TinyMCE wo…
9ad9f56 
…rk in Angular FILEASSET #27969 (#28075)

* fix: make FILEASSET images work with Angular TinyMCE implementation

* fix tests

---------

Co-authored-by: Freddy Montes <[email protected]>
@github-project-automation github-project-automation bot moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Mar 26, 2024
@rjvelazco rjvelazco reopened this Mar 26, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Mar 26, 2024
@rjvelazco
Copy link
Contributor Author

Fixed here: #28075 @zJaaal

@zJaaal zJaaal moved this from Current Sprint Backlog to In Review in dotCMS - Product Planning Mar 26, 2024
@zJaaal zJaaal moved this from In Review to Internal QA in dotCMS - Product Planning Mar 26, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Mar 26, 2024

IQA Passed

Now I can add FileAssets as expected.

@zJaaal zJaaal moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Mar 26, 2024
@josemejias11 josemejias11 moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Mar 28, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on master_1fd3428, Docker, macOS 13.0, FF v121.0.1
Screenshot 2024-04-01 at 12 41 14 PM

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Apr 1, 2024
@zJaaal zJaaal closed this as completed Apr 2, 2024
@github-project-automation github-project-automation bot moved this from Done to Internal QA in dotCMS - Product Planning Apr 2, 2024
@zJaaal zJaaal moved this from Internal QA to Done in dotCMS - Product Planning Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

@rjvelazco rjvelazco

Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 24.04.5 CLI Team : Lunik Triage Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
3 participants
@zJaaal @rjvelazco @josemejias11