Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving a site instead of hitting Save/Activate deactivates the site entirely #28362

Closed
swicken-dotcms opened this issue Apr 25, 2024 · 3 comments · Fixed by #30358
Closed

Saving a site instead of hitting Save/Activate deactivates the site entirely #28362

swicken-dotcms opened this issue Apr 25, 2024 · 3 comments · Fixed by #30358
Assignees
@dsolistorres
Labels
LTS: Needs Backport Ticket that will be added to LTS OKR : Customer Support Owned by Scott Priority : 3 Average QA : Approved Release : 24.11.14 Bug Fixing Team : Bug Fixers Type : Defect

Comments

@swicken-dotcms
Copy link
Contributor

swicken-dotcms commented Apr 25, 2024 •
edited by erickgonzalez
Loading

Parent Issue

No response

Problem Statement

When you save a currently active Site without hitting Save/Activate, it deactivates the site. This is not clear to the user at all, and the history tab still shows a published version.

Steps to Reproduce

  1. Save a site
  2. Try to access the site

Acceptance Criteria

Either
1. The Save action should make it clear that the currently published site will be deactivated
2. The history should not show a published version
Or
The published version should continue to be served and the site must be shown as active.

dotCMS Version

Master, 23.10, 23.01

Proposed Objective

User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/116052
https://dotcms.slack.com/archives/C04UKBYG7SA/p1727116641308499

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@erickgonzalez erickgonzalez moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Apr 25, 2024
@erickgonzalez erickgonzalez moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning May 6, 2024
@erickgonzalez erickgonzalez moved this from Current Sprint Backlog to Next 1-3 Sprints in dotCMS - Product Planning May 17, 2024
@erickgonzalez erickgonzalez moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning May 17, 2024
@erickgonzalez erickgonzalez moved this from Current Sprint Backlog to Next 1-3 Sprints in dotCMS - Product Planning May 17, 2024
@erickgonzalez erickgonzalez moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning May 30, 2024
@erickgonzalez erickgonzalez moved this from Current Sprint Backlog to Next 1-3 Sprints in dotCMS - Product Planning Jun 17, 2024
@dsolistorres dsolistorres self-assigned this Sep 19, 2024
@dsolistorres dsolistorres moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Sep 19, 2024
@dsolistorres dsolistorres mentioned this issue Oct 15, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link

PRs:

dsolistorres added a commit that referenced this issue Oct 16, 2024
@dsolistorres
#28362 : change check for live and working version in findDefaultHost…
fbbfa24 
… method
dsolistorres added a commit that referenced this issue Oct 16, 2024
@dsolistorres
#28362 : change check for live and working version in findDefaultHost…
9eeaf52 
… method
@dsolistorres dsolistorres moved this from In Progress to In Review in dotCMS - Product Planning Oct 17, 2024
dsolistorres added a commit that referenced this issue Oct 18, 2024
@dsolistorres
#28362 : change check for live and working version in findDefaultHost…
d4432b0 
… method
dsolistorres added a commit that referenced this issue Oct 22, 2024
@dsolistorres
#28362 : change check for live and working version in findDefaultHost…
b20b61c 
… method
dsolistorres added a commit that referenced this issue Oct 23, 2024
@dsolistorres
#28362 : fixed postman test to use URL from demo default host
1b5819f
dsolistorres added a commit that referenced this issue Oct 23, 2024
@dsolistorres
#28362 : change check for live and working version in findDefaultHost…
b0013ec 
… method
dsolistorres added a commit that referenced this issue Oct 23, 2024
@dsolistorres
#28362 : fixed postman test to use URL from demo default host
4f82822
dsolistorres added a commit that referenced this issue Oct 29, 2024
@dsolistorres
#28362 : added options for findAllFromDB method on HostAPI
070a3dc
dsolistorres added a commit that referenced this issue Oct 29, 2024
@dsolistorres
#28362 : change check for live and working version in findDefaultHost…
615219b 
… method
dsolistorres added a commit that referenced this issue Oct 29, 2024
@dsolistorres
#28362 : fixed postman test to use URL from demo default host
143ca4a
dsolistorres added a commit that referenced this issue Oct 29, 2024
@dsolistorres
#28362 : added options for findAllFromDB method on HostAPI
e2e3e34
dsolistorres added a commit that referenced this issue Nov 5, 2024
@dsolistorres
#28362 : changed HostSearchOptions class to Search Type enum for clarity
92d2804
github-merge-queue bot pushed a commit that referenced this issue Nov 12, 2024
@dsolistorres @KevinDavilaDotCMS
@zJaaal @jdotcms @wezell @erickgonzalez @hmoreras @jgambarios @nicobytes @rjvelazco @freddyDOTCMS @fabrizzio-dotCMS @dcolina @jcastro-dotcms
fix(hosts) : retrieve live version if a host has live and working ver…
4c5d2c5 
…sions (#30358)

#Closes #28362

### Proposed Changes
* For the sites portlet, if a site has live and working versions, the
live version is shown.
* When resolving a site by name, id or alias, the live version of the
site is retrieved for front-end users.

### Checklist
- [x] Tests

---------

Co-authored-by: Kevin Davila <[email protected]>
Co-authored-by: Jalinson Diaz <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Co-authored-by: Will Ezell <[email protected]>
Co-authored-by: erickgonzalez <[email protected]>
Co-authored-by: Humberto Morera <[email protected]>
Co-authored-by: Jonathan Gamba <[email protected]>
Co-authored-by: Nicolas Molina Monroy <[email protected]>
Co-authored-by: Rafael Velazco <[email protected]>
Co-authored-by: freddyDOTCMS <[email protected]>
Co-authored-by: Fabrizzio Araya <[email protected]>
Co-authored-by: Daniel Enrique Colina Rodríguez <[email protected]>
Co-authored-by: Jose Castro <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Nov 12, 2024
@erickgonzalez
Copy link
Contributor

Working as it should now, when having different live and working versions of a site, the site still renders successfully.

Screenshot 2024-11-13 at 2 47 46 PM

@erickgonzalez erickgonzalez moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Nov 13, 2024
@bryanboza
Copy link
Member

Fixed, unable to reproduce after this fix.

@erickgonzalez erickgonzalez added the LTS: Needs Backport Ticket that will be added to LTS label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsolistorres dsolistorres

Labels
LTS: Needs Backport Ticket that will be added to LTS OKR : Customer Support Owned by Scott Priority : 3 Average QA : Approved Release : 24.11.14 Bug Fixing Team : Bug Fixers Type : Defect
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(hosts) : retrieve live version if a host has live and working versions dotCMS/core
5 participants
@bryanboza @dsolistorres @erickgonzalez @swicken-dotcms @gortiz-dotcms