-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK: Improve @dotcms/angular Documentation #29212
Comments
Internal QA: Passed. |
The writing is clear, with only a couple of small snags:
Under "Client Usage":
Otherwise, the copy itself reads well. As far as testing the code samples myself, I'm unable to even install the library due to dependency tree issues. Any suggestions on this?
EDIT: Note, same outcome after ensuring |
Failed IQA
Feedback
|
@jdcmsd I was able to run the Angular example without any issues. Could you check if you’re still experiencing the same problem? It’s been a while since our last update, and we’ve made updates to our npm packages, SDK, and examples. Edited: If you run into the same error, record a video if possible |
@rjvelazco I can also run the example without issue; the example is great! The issue I was running into was trying to take a brand new But as Freddy was explaining to me earlier, that's not really the point of that readme, so we don't really need to go into step-by-step instructions, there. That said, some of the templating commands that Freddy and Jalinson were discussing might be interesting to build at some point, to accomplish what I was thinking of. But it's not really a high priority when we have a perfectly good working example project — especially when a user can even do something like a git sparse checkout to clone only the example directory, etc. |
Related to #29212 Update `@dotcms/angular` library documentation and add comprehensive JSDoc comments. * **README Updates**: - Add a clear introduction to the library and its purpose in `core-web/libs/sdk/angular/README.md`. - Include full step-by-step instructions on how to use the library. - Fix minor typos and improve clarity. - Update the example README in `examples/angular/README.md` to include necessary environment variables and tokens, and provide detailed instructions on how to start the example. * **JSDoc Comments**: - Add comprehensive JSDoc comments for all inputs, properties, and methods in `core-web/libs/sdk/angular/src/lib/layout/column/column.component.ts`. - Add comprehensive JSDoc comments for all interfaces and properties in `core-web/libs/sdk/angular/src/lib/models/dotcms.model.ts`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dotCMS/core/issues/29212?shareId=XXXX-XXXX-XXXX-XXXX).
IQA PassedDocumentation on code is clear and concise, the readme is well explained and the steps are clear. |
This has come a long way, and it looks great! As with any doc, we can spend forever fiddling with it — or likewise return to it later if we learn about any special use-cases that a headless dev might need spelled out, etc. But right now, I'm comfortable calling this issue finished. |
Fixed, we cal close this one now based on the @jdcmsd feedback |
Task description
As a developer using the
@dotcms/angular
library, I want the documentation to be clear and easy to follow, so that I can easily understand how to use the library in my projects.Acceptance Criteria
example/angular
, include env variables, tokens, everything needed to start the exampleProblem
For example the library have this:
But is not explaining where
provideDotcmsClient
is coming from, or how to create or anything, is missing to much context.Assumptions & Initiation Needs
N/A
The text was updated successfully, but these errors were encountered: