Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error adding new content when no lang param is send #30237

Closed
erickgonzalez opened this issue Oct 3, 2024 · 2 comments · Fixed by #30245
Closed

Error adding new content when no lang param is send #30237

erickgonzalez opened this issue Oct 3, 2024 · 2 comments · Fixed by #30245
Assignees
@nicobytes
Labels
OKR : Customer Support Owned by Scott Priority : 2 High Release : 24.04.24 v10 Included in LTS patch release 24.04.24 v10 Team : Bug Fixers Team : Falcon Type : Defect

Comments

@erickgonzalez
Copy link
Contributor

erickgonzalez commented Oct 3, 2024 •
edited
Loading

Parent Issue

No response

Problem Statement

When working in the LTSs, it has been noted that there is an issue when attempting to add new content during page edits if the language_id param is not present.
Screenshot 2024-10-03 at 10 17 49 AM

This doesn't happens in main branch since we're always adding the language_id param if is not present.

Steps to Reproduce

1- Go to edit any page
2- Remove the language_id param from the url.
3- Try to add a new content (any type of content)
4- Get the error

Screen.Recording.2024-10-03.at.10.22.09.AM.mov

Acceptance Criteria

Always add the language_id param if it is not present.

dotCMS Version

LTSs: 23.01, 23.10 and 24.04.

Proposed Objective

Customer Support

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.freshdesk.com/a/tickets/27780
https://dotcms.freshdesk.com/a/tickets/27948

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@hmoreras hmoreras self-assigned this Oct 3, 2024
@hmoreras hmoreras moved this from New to In Progress in dotCMS - Product Planning Oct 3, 2024
@hmoreras hmoreras linked a pull request Oct 4, 2024 that will close this issue
fix (edit page): #30237 Error adding new content when no lang param is send #30245
Merged
@hmoreras hmoreras moved this from In Progress to In Review in dotCMS - Product Planning Oct 4, 2024
erickgonzalez pushed a commit that referenced this issue Oct 4, 2024
@hmoreras
fix (edit page): #30237 Error adding new content when no lang param i…
01cd9b8 
…s send (#30245)

### Proposed Changes
* If the user send the URL without the language ID, we will set the
default one, to avoid incorrect behaviour when creating a content.
@erickgonzalez erickgonzalez added LTS: Needs Backport Ticket that will be added to LTS Team : Bug Fixers LTS: Next Patch Shortlisted of issues that will be included in the upcoming LTS patch and removed LTS: Needs Backport Ticket that will be added to LTS labels Oct 4, 2024
@nicobytes nicobytes assigned nicobytes and unassigned hmoreras Oct 7, 2024
@hmoreras
Copy link
Contributor

hmoreras commented Oct 7, 2024

The QA process will be made by the support team due is a LTS issue.

@erickgonzalez

@erickgonzalez erickgonzalez moved this from Done to Internal QA in dotCMS - Product Planning Oct 8, 2024
@erickgonzalez
Copy link
Contributor Author

It's working as it should now in the 24.04 LTS version. Thanks @hmoreras

@erickgonzalez erickgonzalez moved this from Internal QA to Done in dotCMS - Product Planning Oct 8, 2024
@erickgonzalez erickgonzalez added Release : 24.04.24 v10 Included in LTS patch release 24.04.24 v10 and removed LTS: Next Patch Shortlisted of issues that will be included in the upcoming LTS patch labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicobytes nicobytes

Labels
OKR : Customer Support Owned by Scott Priority : 2 High Release : 24.04.24 v10 Included in LTS patch release 24.04.24 v10 Team : Bug Fixers Team : Falcon Type : Defect
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix (edit page): #30237 Error adding new content when no lang param is send dotCMS/core
3 participants
@erickgonzalez @nicobytes @hmoreras