Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow subaction to submit Content Analytics event #30381

Open
john-thomas-dotcms opened this issue Oct 17, 2024 · 7 comments · Fixed by #30384 or #30500
Open

Workflow subaction to submit Content Analytics event #30381

john-thomas-dotcms opened this issue Oct 17, 2024 · 7 comments · Fixed by #30384 or #30500

Comments

@john-thomas-dotcms
Copy link
Contributor

Parent Issue

No response

User Story

As a developer, I want to collect custom analytics events when users perform specific workflow actions.

Acceptance Criteria

  1. Users can add a Workflow subaction to any Workflow action to record an analytics event.
  2. The subaction allows the user to specify the following information at a minimum:
    • Event type
      • This can be any value EXCEPT the pre-defined event types we record automatically (e.g. PAGE_REQUEST).
    • Object type (e.g. WhatAmI)
      • If the user leaves this blank, the type is set to CONTENT.
    • Object ID
      • If the user leaves this blank, the id is set to the content identifier.
  3. Each time the workflow action is executed, an event is logged to the analytics data store.
  4. The events submitted via workflows may be retrieved the same as all other analytics events (e.g. via API and viewtool).
  5. No information about the event is displayed anywhere (e.g. no growl, no popups, no log messages).
    • If the user wants any messages or notificaions, they can add other subactions for those.

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: FAILED

  • Docker Image: trunk_f2fab7c

The event is not making it to the Clickhouse DB. I'm seeing this message in the log:

dotcms-1      | 17:32:53.184  WARN  actionlet.AnalyticsFireUserEventActionlet - The request or response is null, can't send the event for the contentlet: 60f0234c-8b47-457b-b585-9040cd9fb17e

@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Oct 25, 2024
@jcastro-dotcms jcastro-dotcms moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Oct 25, 2024
@jdotcms
Copy link
Contributor

jdotcms commented Oct 25, 2024

taking a look, thx

@jcastro-dotcms
Copy link
Contributor

jcastro-dotcms commented Oct 29, 2024

NOTE TO INTERNAL QA:

The PR that included the Integration Tests for the Content Analytics classes overwrote one of the required changes for this ticket: https://github.com/dotCMS/core/pull/30465/files#diff-b3262e0c55b89f8f7ebd482593a2c45249e4146e261fd613f72f2ae12a97c0bbL67

This is why the event was not being created in the ClickHouse DB. The Failed Internal label is invalid.

Jonathan will send a new PR with the overwritten change so that this ticket can be tested once more.

Copy link

dsolistorres pushed a commit that referenced this issue Nov 5, 2024
@dsilvam dsilvam assigned jcastro-dotcms and unassigned jdotcms Nov 5, 2024
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: FAILED

  • Docker Image: trunk_70b861a

The event is still not making it to the Clickhouse DB.

@jcastro-dotcms jcastro-dotcms moved this from Internal QA to In Progress in dotCMS - Product Planning Nov 5, 2024
@jdotcms jdotcms moved this from In Review to Internal QA in dotCMS - Product Planning Nov 8, 2024
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: PASSED

  • Docker Image: trunk_7a5f044

The event is making it to the Clickhouse DB when the Workflow Action is called on a test Contentlet, as expected.

@jcastro-dotcms jcastro-dotcms moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Nov 9, 2024
spbolton pushed a commit that referenced this issue Nov 11, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_a5bde22, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment