Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on a locale in the new Locales portlet doesn't to anything #30395

Closed
john-thomas-dotcms opened this issue Oct 18, 2024 · 2 comments · Fixed by #30402
Closed

Click on a locale in the new Locales portlet doesn't to anything #30395

john-thomas-dotcms opened this issue Oct 18, 2024 · 2 comments · Fixed by #30402
Assignees
@dsilvam
Labels
dotCMS : Localization Includes i18n and multi-lingual issues Gardening Day OKR : User Experience Owned by Jason QA : Passed Internal Release : 24.10.25 Bug Fixing Team : Falcon Type : Defect

Comments

@john-thomas-dotcms
Copy link
Contributor

Parent Issue

No response

Problem Statement

The standard behavior for all portlets in dotCMS is that a single-click on an item in a list takes a default action on that item. In the Locales portlet, clicking on a Locale in the list currently does nothing; you need to go click on the hamburger menu on the right to edit it.

We need to change it so a single-click on a Locale in the list opens the edit popup for that Locale.

Steps to Reproduce

  1. Open the Locales portlet.
  2. Click on any Locale in the list.
    Result: Nothing happens.

Acceptance Criteria

  • Click on a Locale in the list opens the edit popup for the clicked Locale.
  • Changes made in the edit popup are saved without issues.

dotCMS Version

Trunk

Proposed Objective

User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@john-thomas-dotcms john-thomas-dotcms moved this from New to Gardening Day Backlog in dotCMS - Product Planning Oct 18, 2024
@hmoreras hmoreras self-assigned this Oct 18, 2024
@hmoreras hmoreras moved this from Gardening Day Backlog to Next 1-3 Sprints in dotCMS - Product Planning Oct 18, 2024
@hmoreras hmoreras linked a pull request Oct 18, 2024 that will close this issue
implemntation ( locales portlet ): #30395 Click on a locale in the new Locales portlet doesn't to anything #30402
Merged
@hmoreras
Copy link
Contributor

video for QA:

Screenshare.-.2024-10-18.11_21_07.AM.mp4

@hmoreras hmoreras moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Oct 18, 2024
@hmoreras hmoreras moved this from In Progress to In Review in dotCMS - Product Planning Oct 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2024
@hmoreras
implemntation ( locales portlet ): #30395 Click on a locale in the ne…
2d60cb6 
…w Locales portlet doesn't to anything (#30402)

### Proposed Changes
* Add click event on row to show the edit popup. 


### Screenshots



https://github.com/user-attachments/assets/2ef16df8-7fa6-47e8-a04b-139d83567a58
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Oct 18, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Oct 21, 2024

Passed IQA: Clicking on a locale now shows the edit locale dialog:

Image

@dsilvam dsilvam moved this from Internal QA to Done in dotCMS - Product Planning Oct 21, 2024
@dsilvam dsilvam assigned dsilvam and unassigned hmoreras Oct 21, 2024
@dsilvam dsilvam added the Release : 24.10.25 Bug Fixing label Oct 21, 2024
spbolton pushed a commit that referenced this issue Nov 11, 2024
@hmoreras @spbolton
implemntation ( locales portlet ): #30395 Click on a locale in the ne…
a17d2a8 
…w Locales portlet doesn't to anything (#30402)

### Proposed Changes
* Add click event on row to show the edit popup. 


### Screenshots



https://github.com/user-attachments/assets/2ef16df8-7fa6-47e8-a04b-139d83567a58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilvam dsilvam

Labels
dotCMS : Localization Includes i18n and multi-lingual issues Gardening Day OKR : User Experience Owned by Jason QA : Passed Internal Release : 24.10.25 Bug Fixing Team : Falcon Type : Defect
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
3 participants
@dsilvam @john-thomas-dotcms @hmoreras