Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-to-end (E2E) setup for the new content editor #31033

Open
4 tasks
nicobytes opened this issue Jan 2, 2025 · 1 comment · Fixed by #31049 · May be fixed by #31044
Open
4 tasks

End-to-end (E2E) setup for the new content editor #31033

nicobytes opened this issue Jan 2, 2025 · 1 comment · Fixed by #31049 · May be fixed by #31044
Assignees
@nicobytes
Labels
dotCMS : Content Management OKR : Quality Assurance Owned by Bryan on hold In Progress, but paused to work on higher priority card Team : Falcon Type : Task Type : Test Automation

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Jan 2, 2025 •
edited
Loading

Parent Issue

No response

Task

Create the setup to run e2e tests for the new edit content.

Proposed Objective

Quality Assurance

Proposed Priority

Priority 3 - Average

Acceptance Criteria

Ensure end-to-end (E2E) tests run on the CI/CD pipeline without issues

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

  • Configure proper teardown to clean up all tests
  • Enable the new content editor
  • Add a script to create a basic content type with all fields
  • Add tests for the text field
@nicobytes nicobytes self-assigned this Jan 2, 2025
@nicobytes nicobytes removed the Triage label Jan 2, 2025
@nicobytes nicobytes moved this from New to In Progress in dotCMS - Product Planning Jan 2, 2025
@nicobytes nicobytes moved this from In Progress to Current Sprint Backlog in dotCMS - Product Planning Jan 2, 2025
@nicobytes nicobytes linked a pull request Jan 2, 2025 that will close this issue
31033 end to end e2e setup for the new content editor #31044
Draft
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

PRs:

@nicobytes nicobytes moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Jan 2, 2025
@nicobytes nicobytes mentioned this issue Jan 3, 2025
Merged
3 tasks
@nicobytes nicobytes linked a pull request Jan 3, 2025 that will close this issue
e2e: add prettier and eslint #31049
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 3, 2025
@nicobytes
e2e: add prettier and eslint (#31049)
cbc0cfb 
### Parent Issue

#31033 

### Proposed Changes

This pull request focuses on improving code consistency and style by
introducing ESLint and Prettier configurations, and updating the
codebase to follow these standards. Additionally, it includes various
minor refactors to enhance readability and maintainability.

### ESLint and Prettier Integration:

*
[`e2e/dotcms-e2e-node/frontend/eslint.config.mjs`](diffhunk://#diff-241320bb32f4b5133881ed06c833557f1ccd6831571408774889abfc07939b68R1-R12):
Added ESLint and Prettier configurations to enforce coding standards.
*
[`e2e/dotcms-e2e-node/frontend/package.json`](diffhunk://#diff-55df4fae14fead853fc15ad1d96168928f86342f5e8480fcab0b5690a181719cR5-R18):
Updated dependencies to include ESLint, Prettier, and related plugins.
Added new scripts for formatting and linting the code.
[[1]](diffhunk://#diff-55df4fae14fead853fc15ad1d96168928f86342f5e8480fcab0b5690a181719cR5-R18)
[[2]](diffhunk://#diff-55df4fae14fead853fc15ad1d96168928f86342f5e8480fcab0b5690a181719cL21-R33)
*
[`e2e/dotcms-e2e-node/frontend/prettier-config.json`](diffhunk://#diff-4ebd1c31f65f9c1ff5371e23ad3eed5b12bac5e78a8897a10e5e8ada832d02a6R1-R11):
Added Prettier configuration file to define code formatting rules.

### Code Consistency and Style Improvements:

*
[`e2e/dotcms-e2e-node/frontend/index.js`](diffhunk://#diff-fbb9f1ca345034b05597b6f3283632a5e243ff52df784f61134429f5125df438L1-R51):
Updated all string literals to use double quotes for consistency.
*
[`e2e/dotcms-e2e-node/frontend/locators/globalLocators.ts`](diffhunk://#diff-35aa7e942a2b3bf721b03086edd81cc7f9f6304c382d1f8d4f63154e8774d7ebL7-R48):
Formatted object properties and added trailing commas for consistency.
*
[`e2e/dotcms-e2e-node/frontend/locators/navigation/menuLocators.ts`](diffhunk://#diff-31116070120de9d34d2d1bca1e15a77b893d11eacd3c4f35c19a97e6724a4728L1-R13):
Formatted code to improve readability and maintain consistent string
quoting.
[[1]](diffhunk://#diff-31116070120de9d34d2d1bca1e15a77b893d11eacd3c4f35c19a97e6724a4728L1-R13)
[[2]](diffhunk://#diff-31116070120de9d34d2d1bca1e15a77b893d11eacd3c4f35c19a97e6724a4728L24-R28)
[[3]](diffhunk://#diff-31116070120de9d34d2d1bca1e15a77b893d11eacd3c4f35c19a97e6724a4728L44-R47)

### Refactoring and Cleanup:

*
[`e2e/dotcms-e2e-node/frontend/playwright.config.ts`](diffhunk://#diff-2db21369684b5f6dd698eb7a6eb71c0d0a92d245e61e26ed3a3c33bed5f6d0faL1-R32):
Refactored configuration file to use consistent string literals and
improved readability.
[[1]](diffhunk://#diff-2db21369684b5f6dd698eb7a6eb71c0d0a92d245e61e26ed3a3c33bed5f6d0faL1-R32)
[[2]](diffhunk://#diff-2db21369684b5f6dd698eb7a6eb71c0d0a92d245e61e26ed3a3c33bed5f6d0faL44-R41)
[[3]](diffhunk://#diff-2db21369684b5f6dd698eb7a6eb71c0d0a92d245e61e26ed3a3c33bed5f6d0faL61-R65)
[[4]](diffhunk://#diff-2db21369684b5f6dd698eb7a6eb71c0d0a92d245e61e26ed3a3c33bed5f6d0faL82-R83)
*
[`e2e/dotcms-e2e-node/frontend/tests/contentSearch/contentData.ts`](diffhunk://#diff-932c6ee4fda04337ff2a3c40079ff9aec9fb484641921760730a96a53d3c41afL1-R9):
Cleaned up and formatted content data file for better readability.
[[1]](diffhunk://#diff-932c6ee4fda04337ff2a3c40079ff9aec9fb484641921760730a96a53d3c41afL1-R9)
[[2]](diffhunk://#diff-932c6ee4fda04337ff2a3c40079ff9aec9fb484641921760730a96a53d3c41afL22-R31)
[[3]](diffhunk://#diff-932c6ee4fda04337ff2a3c40079ff9aec9fb484641921760730a96a53d3c41afL42-R41)
*
[`e2e/dotcms-e2e-node/frontend/tests/contentSearch/contentEditing.spec.ts`](diffhunk://#diff-15b7d158a73d1a05b76e931e23509af650c9dd6a9f3c281244851f538a682b17L1-R30):
Refactored test file to improve readability and maintain consistent
string quoting.
[[1]](diffhunk://#diff-15b7d158a73d1a05b76e931e23509af650c9dd6a9f3c281244851f538a682b17L1-R30)
[[2]](diffhunk://#diff-15b7d158a73d1a05b76e931e23509af650c9dd6a9f3c281244851f538a682b17L30-R139)


### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)
@github-project-automation github-project-automation bot moved this from In Progress to Done in dotCMS - Product Planning Jan 3, 2025
@nicobytes nicobytes moved this from Done to In Progress in dotCMS - Product Planning Jan 6, 2025
@nicobytes nicobytes reopened this Jan 6, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Current Sprint Backlog in dotCMS - Product Planning Jan 6, 2025
@nicobytes nicobytes moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Jan 6, 2025
@nicobytes nicobytes added the on hold In Progress, but paused to work on higher priority card label Jan 7, 2025
@nicobytes nicobytes moved this from In Progress to Current Sprint Backlog in dotCMS - Product Planning Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicobytes nicobytes

Labels
dotCMS : Content Management OKR : Quality Assurance Owned by Bryan on hold In Progress, but paused to work on higher priority card Team : Falcon Type : Task Type : Test Automation
Projects
dotCMS - Product Planning
Status: Current Sprint Backlog
Milestone
No milestone
1 participant
@nicobytes