Type '{ prettyLog: false; }' is not assignable to type 'boolean

[robokonk]

I have problem with 'prettyLog', ts show me:

Type '{ prettyLog: false; }' is not assignable to type 'boolean | YogaLogger | undefined'.
  Object literal may only specify known properties, and 'prettyLog' does not exist in type 'YogaLogger'.

What I need to do? My code bellow:

import { join } from "path";
import { readFileSync } from "fs";
import { createServer } from "@graphql-yoga/node";

const typeDefs = readFileSync(join(process.cwd(), "schema.graphql"), {
  encoding: "utf-8",
});

const resolvers = {
  Query: {
    cart: (_, { id }) => {
      return {
        id,
        totalItems: 0,
      };
    },
  },
};

const server = createServer({
  cors: false,
  endpoint: "/api",
  logging: {
    prettyLog: false,
  },
  schema: {
    typeDefs,
    resolvers,
  },
});

export default server;

[ardatan]

We used to have that option in early versions of Yoga v2 that uses Pino. Currently Yoga v2 doesn't have that kind of an option and it uses its own simple logger impl.

[robokonk]

Thanks, I installed pino now, and using next.js,

my code is locate pages/api/index.ts, typeScript showed me error:

my code

const server = createServer({
  endpoint: "/api",
  logger,
  schema: {
    typeDefs,
    resolvers,
  },
  context: createContext(),
});

export default server.requestListener;

ts error:

Argument of type '{ endpoint: string; logger: Logger<LoggerOptions | DestinationStream>; schema: { typeDefs: string; resolvers: Resolvers<GraphQLContext>; }; context: Promise<...>; }' is not assignable to parameter of type 'YogaNodeServerOptions<{ req: IncomingMessage; res: ServerResponse; }, GraphQLContext, CartItem>'.
  Object literal may only specify known properties, and 'logger' does not exist in type 'YogaNodeServerOptions<{ req: IncomingMessage; res: ServerResponse; }, GraphQLContext, CartItem>'.ts(2345)

What is wrong?

[ardatan]

It is logging not logger. https://github.com/dotansimha/graphql-yoga/blob/master/packages/common/src/server.ts#L68

We also created an issue for missing documentation about custom loggers;
#1195

[robokonk]

@ardatan thanks for helping, bellow my code:

import createLogger from "pino"

const logging = createLogger()

const server = createServer<{
    req: NextApiRequest;
    res: NextApiResponse;
}>({
    endpoint: "/api",
    logging,
    schema: {
        typeDefs,
        resolvers,
    },
    context: createContext(),
});

export default server.requestListener;

I didn't see any log, but I running next by command:
npm run dev | pino-pretty

Any ideas?

[ardatan]

Please create an issue with a reproduction so we can track it there :)