fix: pod cpu/memory usage metrics grouped by id as well #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotdc
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Thank you for the fix @martin-ilavsky, could you just bump the dashboard version at the end of the file?
martin-ilavsky
force-pushed
the
pod_view_cpu_mem_metrics
branch
from
ffb64d7
to
98dd4e2
Compare
|
@dotdc done |
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Required Fields
🔎 What kind of change is it?
🎯 What has been changed and why do we need it?
idto group by for cpu/memory usage. When pod restarts the prometheus metrics for old and new pod sometimes overlap, creating spike in memory and cpu usage when 2 metrics are sumed together. Plotting then the incorectly high values which may be used to set up pod resources and limits incorrectly. See added screenshot where red and yellow lines are slightly overlapping which would cause spike withoutid.