Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not standard manufacturer data #612

Open
darrillaga opened this issue Sep 22, 2021 · 1 comment
Open

Not standard manufacturer data #612

darrillaga opened this issue Sep 22, 2021 · 1 comment

Comments

@darrillaga
Copy link

darrillaga commented Sep 22, 2021

Hi,

I'm working with specific hardware which advertises two manufacturer data payloads but for same manufacturer id. For some reason iOS takes the one I need and everything works, but android library takes the other one (since there are two 0xFF types overrides the first with the second), so it does not work, ref at: https://github.com/dotintent/MultiPlatformBleAdapter/blob/669e438acb384eee74f3f1ada3ba259cf7b7965b/android/library/src/main/java/com/polidea/multiplatformbleadapter/AdvertisementData.java#L197.

I'm not pretending a change for this behavior since it does not seem to be standard, but I saw that MultiPlatformBLEAdapter exposes the raw data of the scan result which is enough to manage this custom scenario and I think it would be of help to other in same non standard situations.

Would you accept to start exposing to flutter layer also the raw bytes of the advertisement data?

I tried to imagine what the cons would be and I see that passing the bytes alongside some parsed data is already on it would be a little bit redundant. I also see iOS won't provide the exact same data on for this requirement than android does.

For reference I'm talking about data available in https://github.com/dotintent/MultiPlatformBleAdapter/blob/669e438acb384eee74f3f1ada3ba259cf7b7965b/android/library/src/main/java/com/polidea/multiplatformbleadapter/AdvertisementData.java#L49

In case this is seen as a good nice to have I could elaborate a little bit more and prepare a merge request.

Thanks!

@darrillaga
Copy link
Author

Did some more investigation and it's seems the way the data arrives is due to android doing active BLE scan and it seems there is no easy way to turn it into passive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant