Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

README.md - "This project is part of ASP.NET Core." #65

Open
espray opened this issue Aug 29, 2017 · 9 comments
Open

README.md - "This project is part of ASP.NET Core." #65

espray opened this issue Aug 29, 2017 · 9 comments

Comments

@espray
Copy link

espray commented Aug 29, 2017

The README.md says "This project is part of ASP.NET Core."
What does this mean?
Has this project moved?

@CESARDELATORRE
Copy link
Contributor

It is still in Alpha here. Will be, eventually released. Hopefully in .NET Core 2.1 release, but I cannot confirm for sure.

@espray
Copy link
Author

espray commented Aug 29, 2017

@CESARDELATORRE thanks for the reply
Will this be the repro to watch, or will the work be done in different repro, or TBD?

@CESARDELATORRE
Copy link
Contributor

For now, this is it, but it might change. If that happens, we'll announce it here. :)

@ekarlso
Copy link

ekarlso commented Sep 29, 2017

How to use the healthcheck code then ?

@espray
Copy link
Author

espray commented Sep 29, 2017

I forked the code and included the projs in my solution. When a Nuget package is created I will switch to that

@rjperes
Copy link

rjperes commented Oct 19, 2017

@ekarlso : see this post: https://scottsauber.com/2017/05/22/using-the-microsoft-aspnetcore-healthchecks-package/

@CESARDELATORRE
Copy link
Contributor

Also, see this documentation:
https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/implement-resilient-applications/monitor-app-health

@JuergenGutsch
Copy link
Contributor

Maybe it would make sense to change the readme anyway, because it is currently lying to the readers:

You can find samples, documentation and getting started instructions for ASP.NET Core at the Home repo.

https://github.com/aspnet/Home/search?utf8=%E2%9C%93&q=HealthChecks&type=Code

@CESARDELATORRE
Copy link
Contributor

CESARDELATORRE commented Dec 6, 2017

Thanks for the feedback. I changed the text so it is not confusing.
Those mentioned samples are just about ASP.NET Core, not about HealthCheck library.
The examples of HealthCheck library are within this same repo or eShopOnContainers which is also using this library: https://github.com/dotnet-architecture/eShopOnContainers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants