Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nightly dogfooding devcontainer #6767

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Nov 22, 2024

Description

Adds a dogfooding devcontainer that can be used to setup an environment where people can test the latest version of aspire pushed to our nightly feeds. After this one goes in, we can also build one that uses live-built bits.

cc: @mitchdenny

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

"GitHub.copilot-chat",
"GitHub.copilot"
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider all of those but for the other devcontainer (the contributing one) which is already checked in (cc: @mitchdenny ) That is because most of those settings relate to working on the repo itself, and that is what our contributing dev container is for. This one that I'm adding here, is instead for having a blank slate that has latest nightly installed in an empty workspace with the right nuget.config defined, so anyone can dogfood aspire's latest build from main. The settings you pointed out may not be applicable for this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha

@joperezr
Copy link
Member Author

Thanks folks!

@joperezr joperezr merged commit d8fedda into dotnet:main Nov 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants