Implement the Mvc PushFileStreamResult API

[0xced]

Mvc PushFileStreamResult API

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

This pull request implements PushFileStreamResult as described in #39383 along with the related File overloads on the ControllerBase class and the PushFileStreamResultExecutor.

Fixes #39383

[captainsafia]

Thanks for taking the time to work on this, @0xced!

This looks good overall. To make sure that everything's checked, can you open a new API proposal issue specifically for the MVC-related changes? I'm hoping the review can happen fairly quickly since they build on top of the IResult-based implementations but I'd like to make sure we get the right scrutiny for the new methods on ControllerBase.

[captainsafia]

Why SkipEnabledCheck = true here?

[0xced]

Because ExecutingFileResultWithNoFileName is already surrounded by if (logger.IsEnabled(LogLevel.Information)) inside the ExecutingFileResult method, exactly like in FileContentResultExecutor.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)

• src/Mvc/Mvc.Core/src/PublicAPI.Unshipped.txt: Language not supported
• src/Mvc/Mvc.Core/test/PushFileStreamResultTest.cs: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/Mvc/Mvc.Core/src/Infrastructure/PushFileStreamResultExecutor.cs:64

• The 'WriteFileAsync' method should handle the 'range' and 'rangeLength' parameters correctly, ensuring they are 'null' and '0' respectively, or handle them appropriately if they are not.

Debug.Assert(range == null);

[0xced]

Please don't close this pull request.

[0xced]

Can I get a human to reopen this pull request please?

[captainsafia]

@0xced Did you get a chance to file an API review issue for this? We'll need to get the API reviewed + approved before merging.

[Rick-Anderson]

@tdykstra please review ///comments.

[0xced]

Did you get a chance to file an API review issue for this? We'll need to get the API reviewed + approved before merging.

I haven't got around yet but I'd like to do it. I just have other priorities right now.

Can we please reopen this again? And maybe also tell the bot to stop closing this PR every week? This bot repeatedly closing pull requests is such hostile behaviour towards contributors. 😟

[Rick-Anderson]

I haven't got around yet but I'd like to do it. I just have other priorities right now.

That's why the bot is closing it. Once you get an API review issue for this, and add Fixes API review issue, the bot should stop closing it.