Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix source build when using --no-build-js #59118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix source build when using --no-build-js #59118

wants to merge 2 commits into from
+16 −3

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Nov 22, 2024 •
edited
Loading

  • Checks in blazor.webview.js
  • Updates Microsoft.AspNetCore.App.Internal.Assets to build successfully when using --no-build-js, even when the framework JS assets are not on disk

Fixes #59114

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner November 22, 2024 19:28
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Nov 22, 2024
javiercn
javiercn reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need --no-build-nodejs for source build, isn't that the case?

Can we not instead update the check so that in that situation just disable the check that triggers the error when we are running inside source build?

Source build doesn't run any code, it just builds it, and the JS assets are not needed for the build step.

@MackinnonBuck
Copy link
Member Author

MackinnonBuck commented Nov 22, 2024 •
edited
Loading

We only need --no-build-nodejs for source build, isn't that the case?

Can we not instead update the check so that in that situation just disable the check that triggers the error when we are running inside source build?

Source build doesn't run any code, it just builds it, and the JS assets are not needed for the build step.

Yeah, that sounds good. I'll update this PR to disable the check if not building with NodeJS.

Eventually I think we'll want to change blazor.webview.js to also not be an embedded resource and instead be included as part of M.A.A.Internal.Assets

@MackinnonBuck MackinnonBuck changed the title Temporarily check in Blazor framework JS files Disable blazor.webview.js check when not building NodeJS Nov 22, 2024
@MackinnonBuck MackinnonBuck changed the title Disable blazor.webview.js check when not building NodeJS Fix source build when using --no-build-js Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@javiercn javiercn Awaiting requested review from javiercn

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building the managed part without node installed doesn't work anymore
3 participants
@MackinnonBuck @javiercn @wtgodbe