Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove product EOL logic from GenerateEolAnnotationDataCommand #1581

Open
mthalman opened this issue Feb 3, 2025 · 0 comments · May be fixed by #1590
Open

Remove product EOL logic from GenerateEolAnnotationDataCommand #1581

mthalman opened this issue Feb 3, 2025 · 0 comments · May be fixed by #1590
Assignees
@mthalman
Labels
area-infrastructure

Comments

@mthalman
Copy link
Member

mthalman commented Feb 3, 2025

Based on the discussion at #1553 (comment), there's no need to keep the logic which checks whether images are associated with an EOL product version:

docker-tools/src/Microsoft.DotNet.ImageBuilder/src/Commands/GenerateEolAnnotationDataCommand.cs

Lines 128 to 140 in 44c7e96

if (Options.AnnotateEolProducts)
{
// Annotate images for EOL products in new image info
// Only do so for those digests that actually exist in the registry (they may have been cleaned up
// because they are EOL).
IEnumerable<EolDigestData> eolDigests =
newImageArtifactDetails.Repos
.SelectMany(repo =>
repo.Images
.SelectMany(image => GetProductEolDigests(image, productEolDates)))
.Where(digestData => registryTagsByDigest.ContainsKey(digestData.Digest));
digestDataList.AddRange(eolDigests);
}

That logic can be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mthalman mthalman

Labels
area-infrastructure
Projects
.NET Docker
Status: Sprint
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete product version EOL handling mthalman/docker-tools
2 participants
@mthalman @lbussell